Open
Conversation
delbarrow
reviewed
Feb 25, 2026
| > | ||
| <div | ||
| role="link" | ||
| role="presentation" |
Contributor
There was a problem hiding this comment.
this should be added to the iframe itself and not the inner div.
| // $FlowFixMe | ||
| const win = frame.contentWindow; | ||
| const button = win.document.querySelector('[role="link"]'); | ||
| const button = win.document.querySelector("[data-button]"); |
Contributor
There was a problem hiding this comment.
we do not need to change the role here we want it to stay link, we just want to add the role on the iframe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merchant - Nike reported accessibility issue with JS v5 iframe.
Two requests:
https://paypal.atlassian.net/browse/LI-144341
Changed Constants in sdk/constants module
paypal/paypal-sdk-constants#165